Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multi_object_tracking): mot bicycle model revision, tracking_object_merger bugfix #1154

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

technolojin
Copy link

@technolojin technolojin commented Feb 21, 2024

Description

cherry-picks of multi_object_tracking
autowarefoundation#6082
autowarefoundation#6337
autowarefoundation#6343

cherry-pick of tracking_object_merger
autowarefoundation#6457

Related links

fix for following issues
https://tier4.atlassian.net/browse/RT1-4914
https://tier4.atlassian.net/browse/RT1-5207
https://tier4.atlassian.net/browse/RT1-5343
https://tier4.atlassian.net/browse/RT1-5257

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

technolojin and others added 3 commits February 21, 2024 09:19
…ation#6082)

* fix: bicycle model length on big vehicle

Signed-off-by: Taekjin LEE <[email protected]>

* fix: rear axis position fix in all modalities

Signed-off-by: Taekjin LEE <[email protected]>

* fix: repeat predict to limit dt

Signed-off-by: Taekjin LEE <[email protected]>

* fix: implement repeating prediction to all modalities

Signed-off-by: Taekjin LEE <[email protected]>

* fix: bicycle model revision

Signed-off-by: Taekjin LEE <[email protected]>

* fix: fix centripetal acceleration,  jacobian

Signed-off-by: Taekjin LEE <[email protected]>

* style(pre-commit): autofix

Signed-off-by: Taekjin LEE <[email protected]>

* chore: equation on description, velocity index fix

Signed-off-by: Taekjin LEE <[email protected]>

* fix: markdown math

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor params

Signed-off-by: Taekjin LEE <[email protected]>

* feat: model slip process rate

Signed-off-by: Taekjin LEE <[email protected]>

* feat: yaw rate limits

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor vx to vel, follow actual definition

Signed-off-by: Taekjin LEE <[email protected]>

* fix: acceleration uncertainty equation fix

Signed-off-by: Taekjin LEE <[email protected]>

* fix: twist covariance matrix

Signed-off-by: Taekjin LEE <[email protected]>

* chore: explanations of Kalman filter matrices

Signed-off-by: Taekjin LEE <[email protected]>

* feat: slip angle process noise model revised

Signed-off-by: Taekjin LEE <[email protected]>

* feat: parameter tuning

Signed-off-by: Taekjin LEE <[email protected]>

* fix: use mahalanobis distance gate with larger threshold

Signed-off-by: Taekjin LEE <[email protected]>

* chore: align tracker format

Signed-off-by: Taekjin LEE <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Taekjin LEE <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Yoshi Ri <[email protected]>
Co-authored-by: Kotaro Yoshimoto <[email protected]>
…o-center length (autowarefoundation#6337)

* fix: bicycle motion model - set minimum wheel-to-center length for stability

Signed-off-by: Taekjin LEE <[email protected]>

* chore: align comments

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
…towarefoundation#6343)

* fix: tune parameters for pedestrian initial covariances and process noise

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactoring comments, aligning trackers

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
@technolojin technolojin self-assigned this Feb 21, 2024
@technolojin technolojin requested a review from shmpwk February 21, 2024 00:36
@technolojin technolojin changed the title fix(multi_object_tracking): mot bicycle model revision fix(multi_object_tracking): mot bicycle model revision, tracking_object_merger bugfix Feb 21, 2024
…rdinate system (autowarefoundation#6457)

fix(tracking_object_merger): merge velocity base on target object coordinate

Signed-off-by: Taekjin LEE <[email protected]>
Copy link
Collaborator

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk shmpwk merged commit fe604a9 into beta/v0.20.1.1 Feb 21, 2024
12 of 13 checks passed
@shmpwk shmpwk deleted the cherry-pick/taekjin branch February 21, 2024 02:10
YoshiRi pushed a commit that referenced this pull request Mar 14, 2024
fix(multi_object_tracking): mot bicycle model revision, tracking_object_merger bugfix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants